I made an inline review comment here:
https://github.com/openjdk/jfx/pull/86#pullrequestreview-353972670
The comment applies to line 33, as can be seen in the PR, but the RFR email incorrectly shows the comment after line 34, which could be confusing for those who are following the review thread from the mailing list:
https://mail.openjdk.java.net/pipermail/openjfx-dev/2020-February/024956.html
---------------------------------------------------------------------------------------------
> 32: import com.sun.javafx.stage.WindowHelper;
> 33: import javafx.scene.control.MenuItem;
> 34: import test.com.sun.javafx.pgstub.StubToolkit;
Minor: can you move this next to the other `javafx.scene.control` imports? (I know they aren't all sorted, but most are)
---------------------------------------------------------------------------------------------
https://github.com/openjdk/jfx/pull/86#pullrequestreview-353972670
The comment applies to line 33, as can be seen in the PR, but the RFR email incorrectly shows the comment after line 34, which could be confusing for those who are following the review thread from the mailing list:
https://mail.openjdk.java.net/pipermail/openjfx-dev/2020-February/024956.html
---------------------------------------------------------------------------------------------
> 32: import com.sun.javafx.stage.WindowHelper;
> 33: import javafx.scene.control.MenuItem;
> 34: import test.com.sun.javafx.pgstub.StubToolkit;
Minor: can you move this next to the other `javafx.scene.control` imports? (I know they aren't all sorted, but most are)
---------------------------------------------------------------------------------------------