Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-677

Controlling email generation for non-normative comments

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Unresolved
    • Icon: P4 P4
    • None
    • None
    • bots
    • None

      Example:

      https://github.com/openjdk/jdk/pull/135

      Dan added "/csr" but I didn't notice so I added "/csr needed" and the bot kindly told me it had already been added. So I edited my comment to say:

      /csr needed
      Edit: I missed that this was already flagged.

      That resulted in an email being generated:

      http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2020-September/041857.html

      which just looks completely weird as all context has been lost:

      On Tue, 15 Sep 2020 01:55:39 GMT, David Holmes <dholmes at openjdk.org> wrote:
      >> Daniel D. Daugherty has updated the pull request incrementally with one additional commit since the last revision:
      >>
      >> rkennke, coleenp, fisk CR - delete random assert() that knows too much about markWords.
      >
      > Marked as reviewed by dholmes (Reviewer).
      Edit: I missed that this was already flagged.
      -----

      Now ideally there would be no email generated for this edit but I realize the bot may have trouble determining that. So instead perhaps a way to indicate no mail should be generated when I add the comment?

            Unassigned Unassigned
            dholmes David Holmes
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: