-
Bug
-
Resolution: Fixed
-
P3
-
None
-
None
-
None
If reviewers are configured in .jcheck/conf, running `git jcheck` locally will correctly fail with an error message if a commit has a sole reviewer who is the same as the author, and there are no other contributors.
However, a pull request under the same conditions will be marked as ready to integrate, and will allow integration of a commit that then fails jcheck.
For an example of this, see:
https://orahub.oraclecorp.com/jpg-sandbox/jfx-sandbox/merge_requests/3
And the resulting commit:
https://orahub.oraclecorp.com/jpg-sandbox/jfx-sandbox/commit/f61b4b3b
When I run jcheck locally, I get this:
$ git jcheck -r f61b4b3b~..f61b4b3b
[reviewers] error: f61b4b3b: self-reviews are not allowed
However, a pull request under the same conditions will be marked as ready to integrate, and will allow integration of a commit that then fails jcheck.
For an example of this, see:
https://orahub.oraclecorp.com/jpg-sandbox/jfx-sandbox/merge_requests/3
And the resulting commit:
https://orahub.oraclecorp.com/jpg-sandbox/jfx-sandbox/commit/f61b4b3b
When I run jcheck locally, I get this:
$ git jcheck -r f61b4b3b~..f61b4b3b
[reviewers] error: f61b4b3b: self-reviews are not allowed