-
Enhancement
-
Resolution: Won't Fix
-
P4
-
None
-
6
-
generic
-
generic
Change hotspot build to use specific path to compilers, using ALT_COMPILER_PATH as an over-ride
Makes builds more consistent with j2se, easier on engineers working on tiger and mustang?
###@###.### 2005-03-09 01:00:16 GMT
The basic problem is that the hotspot/make/Makefile and in general the underlying hotspot makefile system doesn't obey ALT_COMPILER_PATH but expects the compilers and tools to be found in the PATH search. On Windows, every workspace (not just hotspot) has a problem with INCLUDE and LIB needing to be set in the environment, expecting the builder to have set these manually themselves or have used vcvars32.bat supplied by Visual Studio. If we fix the INCLUDE and LIB problem in the j2se/make/common/shared makefiles, then the hotspot/make/Makefile can either get LIB, INCLUDE, and PATH set in the environment before it is invoked in control/make/hotspot-rules.gmk (not ideal), or hotspot/make/Makefile can set CC, CXX, CPP, LINK, LD, etc. (platform specific make variable names?) accordingly, getting LIB, INCLUDE, and COMPILER_PATH as input.
My recommendation would be to leave the hotspot/build/* makefiles alone.
Makes builds more consistent with j2se, easier on engineers working on tiger and mustang?
###@###.### 2005-03-09 01:00:16 GMT
The basic problem is that the hotspot/make/Makefile and in general the underlying hotspot makefile system doesn't obey ALT_COMPILER_PATH but expects the compilers and tools to be found in the PATH search. On Windows, every workspace (not just hotspot) has a problem with INCLUDE and LIB needing to be set in the environment, expecting the builder to have set these manually themselves or have used vcvars32.bat supplied by Visual Studio. If we fix the INCLUDE and LIB problem in the j2se/make/common/shared makefiles, then the hotspot/make/Makefile can either get LIB, INCLUDE, and PATH set in the environment before it is invoked in control/make/hotspot-rules.gmk (not ideal), or hotspot/make/Makefile can set CC, CXX, CPP, LINK, LD, etc. (platform specific make variable names?) accordingly, getting LIB, INCLUDE, and COMPILER_PATH as input.
My recommendation would be to leave the hotspot/build/* makefiles alone.
- relates to
-
JDK-6239789 Isolate construction of ALT_HOTSPOT_IMPORT_PATH area from hotspot builds
-
- Resolved
-