I'm seeing a build failure with awt when using the new Windows compiler (below).

It appears that the awt Makefiles are explicitly using the -WX compiler option that treats
warning errors as fatal errors.
So this is just a warning error, but because of the -WX option it's causing a fatal build error.

So #1, the error needs to be dealt with, and #2 this warnings==fatals issue needs to be dealt with.

These are the 3 places I see the -WX being used:

j2se/make/sun/awt/Makefile: OTHER_CXXFLAGS += -WX
j2se/make/sun/awt/Makefile: OTHER_CFLAGS += -WX
j2se/make/sun/jawt/Makefile: OTHER_CXXFLAGS += -WX

I would recommend the removal of the -WX options from these Makefiles and use COMPILER_WARNINGS_FATAL=true
instead.

It's great that people use COMPILER_WARNINGS_FATAL=true, but risking RE build failures because
of this doesn't seem right.
Ideally only the awt team should build with COMPILER_WARNINGS_FATAL=true and minimize the
risks of fatal build errors by other teams. Making the awt makefiles have a default
of COMPILER_WARNINGS_FATAL=true will require that the awt team has built ALL platforms that
use COMPILER_WARNINGS_FATAL=true (currently windows only) and ALL build variations (product &
fastdebug builds) before they integrate.

It looks like this current problem might only be happening with the fastdebug build on Windows.

Granted this is a special case because I suspect only the new VC++ 7.1 compiler will generate
this error.

Here is the error:

...

C:/PROGRA~1/MICROS~2.NET/Vc7/bin/cl -MD -Zi -Od -W3 -DD3D_OVERLOADS -WX -GX -DUNICODE -D_UNICODE -DDEBUG -DLOGGING -nologo -W3 -DWIN32 -DIAL -D_LITTLE_ENDIAN -DWIN32 -D_X86_ -Dx86 -DWIN32_LEAN_AND_MEAN -FdC:/kto/pjava-mks/control/build/windows-i586-fastdebug/tmp/sun/sun.awt/awt/obj/ -FeC:/kto/pjava-mks/control/build/windows-i586-fastdebug/tmp/sun/sun.awt/awt/obj/ -FmC:/kto/pjava-mks/control/build/windows-i586-fastdebug/tmp/sun/sun.awt/awt/obj/ -I. -IC:/kto/pjava-mks/control/build/windows-i586-fastdebug/tmp/sun/sun.awt/awt/CClassHeaders -I../../../src/windows/javavm/export -I../../../src/share/javavm/export -I../../../src/share/javavm/include -I../../../src/windows/javavm/include -I../../../src/share/native/common -I../../../src/windows/native/common -I../../../src/share/native/sun/awt -I../../../src/windows/native/sun/awt -IC:/kto/pjava-mks/control/build/windows-i586-fastdebug/tmp/sun/sun.awt/awt/CClassHeaders/../../java/jvm
-IC:/kto/pjava-mks/control/build/windows-i586-fastdebug/tmp/sun/sun.awt/awt/obj -I../../../src/share/native/common -I../../../src/windows/native/sun/windows -IC:/DXSDK/Include -I../../../src/share/native/sun/awt/image/cvutils -I../../../src/share/native/sun/awt/image -I../../../src/share/native/sun/java2d/loops -I../../../src/share/native/sun/java2d -I../../../src/windows/native/sun/java2d -I../../../src/share/native/sun/java2d/opengl -I../../../src/windows/native/sun/java2d/d3d -I../../../src/windows/native/sun/java2d/opengl -I../../../src/windows/native/sun/java2d/windows -I../../../src/share/native/sun/font -I../../../src/share/native/sun/java2d/pipe -I../../../src/share/native/sun/dc/path -I../../../src/share/native/sun/dc/doe -I../../../src/share/native/sun/awt/alphacomposite -I../../../src/share/native/sun/awt/debug -I../../../src/share/native/sun/awt/medialib -DINTERNAL_BUILD -c
-FoC:/kto/pjava-mks/control/build/windows-i586-fastdebug/tmp/sun/sun.awt/awt/obj/awt_PopupMenu.obj ../../../src/windows/native/sun/windows/awt_PopupMenu.cpp
awt_PopupMenu.cpp
../../../src\windows\native\sun\windows\awt_PopupMenu.cpp(272) : error C2220: warning treated as error - no object file generated
../../../src\windows\native\sun\windows\awt_PopupMenu.cpp(272) : warning C4345: behavior change: an object of POD type constructed with an initializer of the form () will be default-initialized
gnumake[5]: *** [C:/kto/pjava-mks/control/build/windows-i586-fastdebug/tmp/sun/sun.awt/awt/obj/awt_PopupMenu.obj] Error 2
rm C:/kto/pjava-mks/control/build/windows-i586-fastdebug/tmp/l10n/j2se/sun/awt/windows/awtLocalization_zh_HK.properties
gnumake[5]: Leaving directory `C:/kto/pjava-mks/j2se/make/sun/awt'
gnumake[4]: *** [all] Error 1
gnumake[4]: Leaving directory `C:/kto/pjava-mks/j2se/make/sun'
gnumake[3]: *** [all] Error 1
gnumake[3]: Leaving directory `C:/kto/pjava-mks/j2se/make'
gnumake[2]: *** [j2se-build] Error 2
gnumake[2]: Leaving directory `C:/kto/pjava-mks/control/make'
gnumake[1]: *** [generic_debug_build] Error 2
gnumake[1]: Leaving directory `C:/kto/pjava-mks/control/make'
gnumake: *** [fastdebug_build] Error 2
BUILD FAILED, see logfile
###################################################################



###@###.### 2005-05-30 00:49:50 GMT