Loading...

XML

Word

Printable

Type: Enhancement
Resolution: Fixed
Priority: P3
Fix Version/s: hs25
Affects Version/s: hs24
Component/s: hotspot
Labels:

Subcomponent:
compiler
Resolved In Build:
b12
CPU:

generic
OS:

generic

Issue	Fix Version	Assignee	Priority	Status	Resolution	Resolved In Build
JDK-8004952	8	Christian Thalinger	P3	Resolved	Fixed	b68
JDK-8017861	7u45	Christian Thalinger	P3	Closed	Fixed	b01
JDK-8006367	7u40	Christian Thalinger	P3	Resolved	Fixed	b10
JDK-8004256	hs24	Christian Thalinger	P3	Resolved	Fixed	b29

Most intrinsics in LibraryCallKit re-push the arguments that have been popped off before the call to just pop them again as arguments. It would be much cleaner and more correct to use argument() accessors instead.

Another problem is that it is very tricky to find the places where the stack pointer needs to be adjusted to the correct value for re-execution (uncommon traps). This adjustment is a plain SP bump and decrease after the call. In itself very error prone and it could be handled in a much more elegant way.

backported by

JDK-8004256 C2: instrinsic implementations in LibraryCallKit should use argument() instead of pop()

Resolved

JDK-8004952 C2: instrinsic implementations in LibraryCallKit should use argument() instead of pop()

Resolved

JDK-8006367 C2: instrinsic implementations in LibraryCallKit should use argument() instead of pop()

Resolved

JDK-8017861 C2: instrinsic implementations in LibraryCallKit should use argument() instead of pop()

Closed

duplicates

JDK-7194647 JSR 292: GraphKit::compute_stack_effects needs to be aware of appendix and MemberName arguments

Closed

relates to

JDK-6910605 C2: NullPointerException/ClassCaseException is thrown when C2 with DeoptimizeALot is used

Resolved

JDK-8004319 test/gc/7168848/HumongousAlloc.java fails after 7172640

Resolved

JDK-8006031 LibraryCallKit::inline_array_copyOf disabled unintentionally with 7172640

Resolved

JDK-8004898 library_call.cpp build error after 7172640 with GCC 4.7.2

Resolved

JDK-7023898 Intrinsify AtomicLongFieldUpdater.getAndIncrement()

Resolved

JDK-7184394 add intrinsics to use AES instructions

Resolved

(6 relates to)

Assignee:: Christian Thalinger (Inactive)

Reporter:: Christian Thalinger (Inactive)

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Created:: 2012-05-29 17:26

Updated:: 2013-06-25 21:09

Resolved:: 2012-11-26 20:04

Imported:: 18/Sep/12 12:30 AM

Indexed:: 12/Sep/12 2:10 AM

Details

Backports

Description

Attachments

Issue Links

Activity

People

Dates