-
Bug
-
Resolution: Fixed
-
P4
-
hs25
-
b14
-
generic
-
generic
Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8005652 | 8 | Unassigned | P4 | Resolved | Fixed | b71 |
JDK-8004899 | hs24 | Christian Thalinger | P4 | Closed | Fixed |
http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2012-December/009116.html
Hi,
When I build hsx/hotspot-comp with GCC 4.7.2 on Fedora17, it fails with message as following:
----------
/usr/src/OpenJDK/hsx/fail/hotspot-comp/hotspot/src/share/vm/opto/library_call.cpp: In member function 'CallGenerator* Compile::make_vm_intrinsic(ciMethod*, bool)':
/usr/src/OpenJDK/hsx/fail/hotspot-comp/hotspot/src/share/vm/opto/library_call.cpp:415:67: error: converting 'false' to pointer type 'CallGenerator*' [-Werror=conversion-null]
/usr/src/OpenJDK/hsx/fail/hotspot-comp/hotspot/src/share/vm/opto/library_call.cpp:418:66: error: converting 'false' to pointer type 'CallGenerator*' [-Werror=conversion-null]
/usr/src/OpenJDK/hsx/fail/hotspot-comp/hotspot/src/share/vm/opto/library_call.cpp:421:66: error: converting 'false' to pointer type 'CallGenerator*' [-Werror=conversion-null]
/usr/src/OpenJDK/hsx/fail/hotspot-comp/hotspot/src/share/vm/opto/library_call.cpp:424:66: error: converting 'false' to pointer type 'CallGenerator*' [-Werror=conversion-null]
cc1plus: all warnings being treated as errors
make[6]: *** [library_call.o] Error 1
----------
Cause of this problem is that Compile::make_vm_intrinsic() should return pointer type
(CallGenerator*), however patch of CR#7172640 returns boolean value.
I posted this problem on BugDatabase as a new bug (Internal review ID is 2396515).
However, it does not seem to public yet.
I've made a patch which attached in this email, and it works fine in my environment.
I would like to contribute this patch, and I hope to merge this patch into mainline.
Please cooperate.
Best regards,
Yasumasa
Hi,
When I build hsx/hotspot-comp with GCC 4.7.2 on Fedora17, it fails with message as following:
----------
/usr/src/OpenJDK/hsx/fail/hotspot-comp/hotspot/src/share/vm/opto/library_call.cpp: In member function 'CallGenerator* Compile::make_vm_intrinsic(ciMethod*, bool)':
/usr/src/OpenJDK/hsx/fail/hotspot-comp/hotspot/src/share/vm/opto/library_call.cpp:415:67: error: converting 'false' to pointer type 'CallGenerator*' [-Werror=conversion-null]
/usr/src/OpenJDK/hsx/fail/hotspot-comp/hotspot/src/share/vm/opto/library_call.cpp:418:66: error: converting 'false' to pointer type 'CallGenerator*' [-Werror=conversion-null]
/usr/src/OpenJDK/hsx/fail/hotspot-comp/hotspot/src/share/vm/opto/library_call.cpp:421:66: error: converting 'false' to pointer type 'CallGenerator*' [-Werror=conversion-null]
/usr/src/OpenJDK/hsx/fail/hotspot-comp/hotspot/src/share/vm/opto/library_call.cpp:424:66: error: converting 'false' to pointer type 'CallGenerator*' [-Werror=conversion-null]
cc1plus: all warnings being treated as errors
make[6]: *** [library_call.o] Error 1
----------
Cause of this problem is that Compile::make_vm_intrinsic() should return pointer type
(CallGenerator*), however patch of CR#7172640 returns boolean value.
I posted this problem on BugDatabase as a new bug (Internal review ID is 2396515).
However, it does not seem to public yet.
I've made a patch which attached in this email, and it works fine in my environment.
I would like to contribute this patch, and I hope to merge this patch into mainline.
Please cooperate.
Best regards,
Yasumasa
- backported by
-
JDK-8005652 library_call.cpp build error after 7172640 with GCC 4.7.2
-
- Resolved
-
-
JDK-8004899 library_call.cpp build error after 7172640 with GCC 4.7.2
-
- Closed
-
- relates to
-
JDK-7172640 C2: instrinsic implementations in LibraryCallKit should use argument() instead of pop()
-
- Resolved
-