-
Enhancement
-
Resolution: Fixed
-
P4
-
8, 9
Typical code in CssStyleHelper is
Styleable parent = node.getStyleableParent();
CssStyleHelper styleHelper = this;
while (parent != null) {
styleHelper = parent instanceof Node ? ((Node)parent).styleHelper : null;
if (styleHelper != null) break;
parent = parent.getStyleableParent();
}
If you are deep in the scene graph, it may be that you get to the Control and have to go through several parents to get to the root style helper. If CssStyleHelper had a ref to a parent CssStyleHelper, then this code is just.
CssStyleHelper styleHelper = this.getParentStyleHelper();
Maybe parent isn't such a good name for it. Maybe "upstream"?
Styleable parent = node.getStyleableParent();
CssStyleHelper styleHelper = this;
while (parent != null) {
styleHelper = parent instanceof Node ? ((Node)parent).styleHelper : null;
if (styleHelper != null) break;
parent = parent.getStyleableParent();
}
If you are deep in the scene graph, it may be that you get to the Control and have to go through several parents to get to the root style helper. If CssStyleHelper had a ref to a parent CssStyleHelper, then this code is just.
CssStyleHelper styleHelper = this.getParentStyleHelper();
Maybe parent isn't such a good name for it. Maybe "upstream"?
- blocks
-
JDK-8090757 Improve JavaFX embedded performance
-
- Open
-
- relates to
-
JDK-8187955 CssStyleHelper : recursion in isUserSetFont() can be avoided
-
- Open
-
-
JDK-8237469 Inherited styles don't update when node is moved
-
- Resolved
-
-
JDK-8234877 Changing CSS style of Button sometimes fails to take effect
-
- Closed
-
-
JDK-8177635 Optimise CSS lookup resolution
-
- Open
-