Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8090462

CSS performance: Link style helpers together to avoid going through parent chain looking for parent style helpers

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Fixed
    • P4
    • 10
    • 8, 9
    • javafx

    Description

      Typical code in CssStyleHelper is

      Styleable parent = node.getStyleableParent();
      CssStyleHelper styleHelper = this;
      while (parent != null) {
         styleHelper = parent instanceof Node ? ((Node)parent).styleHelper : null;
         if (styleHelper != null) break;
         parent = parent.getStyleableParent();
      }

      If you are deep in the scene graph, it may be that you get to the Control and have to go through several parents to get to the root style helper. If CssStyleHelper had a ref to a parent CssStyleHelper, then this code is just.

      CssStyleHelper styleHelper = this.getParentStyleHelper();

      Maybe parent isn't such a good name for it. Maybe "upstream"?

      Attachments

        1. Main.java
          2 kB
          Ajit Ghaisas
        2. Test.java
          3 kB
          Ajit Ghaisas

        Issue Links

          blocks

          Enhancement - null JDK-8090757 Improve JavaFX embedded performance

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Open
          relates to

          Bug - A problem which impairs or prevents the functions of the product. JDK-8187955 CssStyleHelper : recursion in isUserSetFont() can be avoided

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. JDK-8237469 Inherited styles don't update when node is moved

          • P3 - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-8234877 Changing CSS style of Button sometimes fails to take effect

          • P3 - Major loss of function.
          • Closed

          Enhancement - null JDK-8177635 Optimise CSS lookup resolution

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Activity

            People

              aghaisas Ajit Ghaisas
              dgrieve David Grieve
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                Imported: