-
Sub-task
-
Resolution: Fixed
-
P4
-
None
-
b15
-
Verified
Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8204037 | 11.0.1 | Hamlin Li | P4 | Resolved | Fixed | team |
In JDK repo, the Unicode character related tests cases are under open/test/jdk/java/lang/Character and open/test/jdk/java/lang/String directories.
In SQE GS-auto repo, there are 30 Unicode character related tests cases need to migrate:
(1) 16 tests are already covered by existing regression tests, these tests will be dropped.
(2) 12 tests are not covered by existing regression tests, these tests will be added.
Add CharPropTest.java to cover the 12 tests. The tests check j.l.Character.isDigit/isLetter/isLetterOrDigit/isSpaceChar/isWhitespace/isTitleCase/isISOControl/isIdentifierIgnorable/isJavaIdentifierStart/isJavaIdentifierPart/isUnicodeIdentifierStart/isUnicodeIdentifierPart methods.
(3) 2 tests are partially covered by existing regression tests, these tests will be integrated.
1) Regression test java/lang/Character/CheckBlocks.java checks if every Unicode Block in Blocks.txt have a Filed in Character.UnicodeBlock class. Add a method to check if every Field of Character.UnicodeBlock is a valid Unicode Block in Blocks.txt.
2) Regression test java/lang/Character/CheckBlocks.java checks Character.UnicodeBlock.of(int codePoint). It only checks three code points for every Unicode Block in Blocks.txt: block head, the code point after head and block end. Add a loop to check all code points between block head and block end.
3) Move CheckBlocks.java from java/lang/Character to java/lang/Character/UnicodeBlock.
(4) Remove regression test: java/lang/Character/TestISOControls.java
It only checks a few values: "-1" and some valid code points. java/lang/Character/TestNegativeCodepoint.java also checks "isISOControl" method with "-1". The new added test CharPropTest.java checks all defined Unicode code points, so delete TestISOControls.java
In SQE GS-auto repo, there are 30 Unicode character related tests cases need to migrate:
(1) 16 tests are already covered by existing regression tests, these tests will be dropped.
(2) 12 tests are not covered by existing regression tests, these tests will be added.
Add CharPropTest.java to cover the 12 tests. The tests check j.l.Character.isDigit/isLetter/isLetterOrDigit/isSpaceChar/isWhitespace/isTitleCase/isISOControl/isIdentifierIgnorable/isJavaIdentifierStart/isJavaIdentifierPart/isUnicodeIdentifierStart/isUnicodeIdentifierPart methods.
(3) 2 tests are partially covered by existing regression tests, these tests will be integrated.
1) Regression test java/lang/Character/CheckBlocks.java checks if every Unicode Block in Blocks.txt have a Filed in Character.UnicodeBlock class. Add a method to check if every Field of Character.UnicodeBlock is a valid Unicode Block in Blocks.txt.
2) Regression test java/lang/Character/CheckBlocks.java checks Character.UnicodeBlock.of(int codePoint). It only checks three code points for every Unicode Block in Blocks.txt: block head, the code point after head and block end. Add a loop to check all code points between block head and block end.
3) Move CheckBlocks.java from java/lang/Character to java/lang/Character/UnicodeBlock.
(4) Remove regression test: java/lang/Character/TestISOControls.java
It only checks a few values: "-1" and some valid code points. java/lang/Character/TestNegativeCodepoint.java also checks "isISOControl" method with "-1". The new added test CharPropTest.java checks all defined Unicode code points, so delete TestISOControls.java
- backported by
-
JDK-8204037 Migrate Unicode character tests to JDK Repo.
-
- Resolved
-