-
Bug
-
Resolution: Fixed
-
P4
-
13
-
None
-
b12
with the fix for JDK-8219971 a syntax error was introduced to the CreateVSProject.gmk file. In the code starting at line 147 there is one to many closing parenthesis ('$(call FixPath, $(VCPROJ_FILE)))')
After changing
$(eval $(call SetupExecute, vcproj_file, \
INFO := Generating Visual Studio project file, \
DEPS := $(BUILD_PROJECT_CREATOR) $(VCPROJ_VARDEPS_FILE), \
OUTPUT_FILE := $(VCPROJ_FILE), \
COMMAND := $(PROJECT_CREATOR_TOOL) $(PROJECT_CREATOR_CLASS) \
$(PROJECT_CREATOR_ARGS) -projectFileName $(call FixPath, $(VCPROJ_FILE))) \
$(LOG_INFO), \
))
to this
$(eval $(call SetupExecute, vcproj_file, \
INFO := Generating Visual Studio project file, \
DEPS := $(BUILD_PROJECT_CREATOR) $(VCPROJ_VARDEPS_FILE), \
OUTPUT_FILE := $(VCPROJ_FILE), \
COMMAND := $(PROJECT_CREATOR_TOOL) $(PROJECT_CREATOR_CLASS) \
$(PROJECT_CREATOR_ARGS) -projectFileName $(call FixPath, $(VCPROJ_FILE)) \
$(LOG_INFO), \
))
and adding the missing 'include Execute.gmk', the target works again.
After changing
$(eval $(call SetupExecute, vcproj_file, \
INFO := Generating Visual Studio project file, \
DEPS := $(BUILD_PROJECT_CREATOR) $(VCPROJ_VARDEPS_FILE), \
OUTPUT_FILE := $(VCPROJ_FILE), \
COMMAND := $(PROJECT_CREATOR_TOOL) $(PROJECT_CREATOR_CLASS) \
$(PROJECT_CREATOR_ARGS) -projectFileName $(call FixPath, $(VCPROJ_FILE))) \
$(LOG_INFO), \
))
to this
$(eval $(call SetupExecute, vcproj_file, \
INFO := Generating Visual Studio project file, \
DEPS := $(BUILD_PROJECT_CREATOR) $(VCPROJ_VARDEPS_FILE), \
OUTPUT_FILE := $(VCPROJ_FILE), \
COMMAND := $(PROJECT_CREATOR_TOOL) $(PROJECT_CREATOR_CLASS) \
$(PROJECT_CREATOR_ARGS) -projectFileName $(call FixPath, $(VCPROJ_FILE)) \
$(LOG_INFO), \
))
and adding the missing 'include Execute.gmk', the target works again.
- relates to
-
JDK-8219971 Introduce SetupExecute in build system
- Resolved