Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8238988

Rename thread "in stack" methods and add is_in_stack_range

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Fixed
    • P4
    • 15
    • 15
    • hotspot
    • None
    • b12

    Description

      Following on from JDK-8234372:

      I think some renaming is needed here:

      Thread::is_in_stack -> Thread::is_in_live_stack
      Thread::on_local_stack -> Thread::is_in_full_stack // I wanted to use "mapped" to imply full stack segment but "mapped" has a special meaning at the OS page level

      We should also add is_in_stack_range that takes a limit and checks that stack_base() > addr >= limit && limit <= stack_end(). This will avoid direct uses of stack_base() in many cases and avoid problems with checking >= versus > etc. Whether the limit is inclusive or exclusive may also have to be specified.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. JDK-8239895 assert(_stack_base != 0LL) failed: Sanity check

          • P3 - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-8240231 Build failure on illumos after 8238988

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-8234372 Investigate use of Thread::stack_base() and queries for "in stack"

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-8240141 Incorrect copyright header in src/hotspot/os_cpu/linux_sparc/os_linux_sparc.cpp

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            People

              dholmes David Holmes
              dholmes David Holmes
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: