Build failure on illumos after 8238988

On 2/28/20 8:16 AM, Peter Tribble wrote:
> Hi,
>
> I'm building from source on illumos. After
>
> 8238988: Rename thread "in stack" methods and add in_stack_range
>
> I get a build failure:
>
> "/export/home/ptribble/ud/jdk-jdk-15+12/src/hotspot/os_cpu/solaris_x86/thread_solaris_x86.cpp",
> line 92: Error: Formal argument limit of type unsigned char* in call to
> Thread::is_in_stack_range_incl(unsigned char*, unsigned char*) const is
> being passed long*.
> 1 Error(s) detected.
>
> Looking at line 92 of src/hotspot/os_cpu/solaris_x86/thread_solaris_x86.cpp:
>
> if (!jt->is_in_stack_range_incl((address)ret_fp, ret_sp)) {
>
> shouldn't the 2nd argument also be cast, as the signature has both being
> the same type? Like so:
>
> if (!jt->is_in_stack_range_incl((address)ret_fp, (address)ret_sp)) {
>
> with that change, I get a clean build again, and a working jdk.
>
> Thanks,
>