Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8243393

Improve ReservedSpace constructor resolution

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Fixed
    • P4
    • 15
    • None
    • hotspot
    • None
    • b21

    Description

      We have

        ReservedSpace(size_t size, size_t alignment, bool large,
                               char* requested_address = NULL);

      and

        ReservedSpace(size_t size, size_t alignment, bool large, bool executable);

      It is way too easy to accidentally get the wrong constructor without getting a build warning. E.g. passing an "address" instead of a char* to the first variant will get me always the second variant, resulting in weird runtime errors later.

      This should be less fragile.

      Attachments

        Issue Links

          Activity

            People

              coleenp Coleen Phillimore
              stuefe Thomas Stuefe
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: