This two-arg constructor can be accidentally used instead of the 4-arg constructor and the one caller in g1 and the 3 in shenandoah can use the 4 arg constructor instead to specify alignment and large pages.
I have a tested patch for this but not sure if it covers the cross product of windows where os::vm_allocation_granularity != os::vm_page_size, and UseLargePages correctly, or how to tell. So assigning to category GC.
I have a tested patch for this but not sure if it covers the cross product of windows where os::vm_allocation_granularity != os::vm_page_size, and UseLargePages correctly, or how to tell. So assigning to category GC.
- relates to
-
JDK-8243393 Improve ReservedSpace constructor resolution
- Resolved
-
JDK-8265268 Unify ReservedSpace reservation code in initialize and try_reserve_heap
- Resolved
-
JDK-8244107 Incorrect parameters in ReservedSpace constructor change
- Resolved
-
JDK-8265066 Split ReservedSpace constructor to avoid default parameter
- Resolved