Cleanup: TableCellSkin is disposed twice

XMLWordPrintable

    • Type: Bug
    • Resolution: Unresolved
    • Priority: P4
    • tbd
    • Affects Version/s: jfx15
    • Component/s: javafx

      TableRowSkinBase.recreateCells() method makes below two calls to dispose the skin.
      cell.getSkin().dispose() and cell.setSkin(null)

      Only one of these two calls is sufficient to dispose the skin.
      Before JDK-8244112 was fixed, above two calls caused an NPE.
      JDK-8244112 safe guards the dispose() method. But as a cleanup one of the two calls (preferably cell.getSkin().dispose()) should be removed.

      We should also find other similar instances and fix them together.

            Assignee:
            Ambarish Rapte
            Reporter:
            Ambarish Rapte
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: