Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8279005

sun/tools/jstat tests do not check for test case exit codes after JDK-8245129

XMLWordPrintable

      I believe there is test regression introduced by JDK-8245129. That change added two test lines, but it never checks the exit code for the first test line.

      If we add the explicit exit code checks, like:

      ${JSTAT} ${COMMON_JSTAT_FLAGS} -gcutil 0 250 5 2>&1 | awk -f ${TESTSRC}/lineCounts1.awk
      RC=$?
      if [ $RC -ne 0 ]; then
        exit $RC
      fi

      ${JSTAT} ${COMMON_JSTAT_FLAGS} -J-XX:+UseParallelGC -gcutil 0 250 5 2>&1 | awk -f ${TESTSRC}/lineCounts1.awk
      RC=$?
      if [ $RC -ne 0 ]; then
        exit $RC
      fi

      ...then the test fails on current VMs:

      $ CONF=linux-x86_64-server-fastdebug make run-test TEST=sun/tools/jstat/jstatLineCounts1.sh

      STDOUT:
        S0 S1 E O M CCS YGC YGCT FGC FGCT CGC CGCT GCT
        0.00 0.00 0.00 0.00 - - 0 0.000 0 0.000 0 0.000 0.000
        0.00 0.00 0.00 0.00 - - 0 0.000 0 0.000 0 0.000 0.000
        0.00 0.00 0.00 0.00 - - 0 0.000 0 0.000 0 0.000 0.000
        0.00 0.00 0.00 0.00 - - 0 0.000 0 0.000 0 0.000 0.000
        0.00 0.00 0.00 0.00 - - 0 0.000 0 0.000 0 0.000 0.000

      The first case produces "M" and "CCS" columns as "-", which is not accepted by the current regexp.

            phh Paul Hohensee
            shade Aleksey Shipilev
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: