Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: P2
Fix Version/s: jfx22
Affects Version/s: jfx11, jfx17, jfx21, jfx22
Component/s: javafx
Labels:

Subcomponent:
other
Resolved In Build:
b16

Issue	Fix Version	Assignee	Priority	Status	Resolution	Resolved In Build
JDK-8319240	jfx21.0.2	Kevin Rushforth	P2	Resolved	Fixed	b03
JDK-8319291	jfx17.0.10	Johan Vos	P2	Resolved	Fixed	b01

A recent change to Skara in processing of the .jcheck/conf file (~~SKARA-2080~~) introduced a bug in processing the [reviewers] section that causes the `/reviewers` command to be ignored in some cases. This is tracked by ~~SKARA-2088~~. The reason we tripped over this bug is that the .jcheck/conf file used by jfx (including various update release repos) uses an unrecognized key, "minimum", instead of the expected "reviewers" key to indicate the minimum number of reviewers. We should fix this to be consistent with what Skara expects given the intent of our [checks "reviewers"] section

backported by

JDK-8319240 Unrecognized "minimum" key in .jcheck/conf causes /reviewers command to be ignored

Resolved

JDK-8319291 Unrecognized "minimum" key in .jcheck/conf causes /reviewers command to be ignored

Resolved

relates to

SKARA-2088 Skara /reviewers command is no longer effective

Resolved

links to

Commit openjdk/jfx17u/192480a4

Commit openjdk/jfx21u/916df936

Commit openjdk/jfx-tests/5c61910d

Commit openjdk/jfx/72c052ee

Review openjdk/jfx17u/167

Review openjdk/jfx21u/24

Review openjdk/jfx-tests/14

Review openjdk/jfx/1275

(6 links to)

Assignee:: Kevin Rushforth

Reporter:: Kevin Rushforth

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Created:: 2023-11-01 08:11

Updated:: 2023-11-07 16:06

Resolved:: 2023-11-01 09:09

Details

Backports

Description

Attachments

Issue Links

Activity

People

Dates