Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8321151

JDK-8294427 breaks Windows L&F on all older Windows versions

    XMLWordPrintable

Details

    • b04
    • 22
    • b04

    Backports

      Description

        https://bugs.openjdk.org/browse/JDK-8294427 starts to use this API
        https://learn.microsoft.com/en-us/windows/win32/api/uxtheme/nf-uxtheme-openthemedatafordpi

        which was introduced only in Windows 10 1703.
        So the theming engine won't load on anything earlier like the original windows 10 or windows 8.1 etc.

        So as an undocumented side-effect it completely breaks the theming of Windows L&F on anything earlier
        and it falls back to hard-coded rendering like Windows NT/Windows 2000

        Whilst those older versions are technically out of at least "mainstream" support, this is not the way
        to make that breaking change and I see this fix has been backported to older releases which expect stability

        it seems to me that this code should NOT fail if the new API is missing and instead fall back to the old code.
        No one will care about a pixel being off on hi-dpi if the entire UI is wrong.


        To reproduce the bug, start SwingSet2, then under the “Look & Feel” menu click “Windows Style Look & Feel”. Any other Swing application in Windows Look & Feel can be used to reproduce the bug.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8324224 JDK-8294427 breaks Windows L&F on all older Windows versions

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8325988 JDK-8294427 breaks Windows L&F on all older Windows versions

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8325989 JDK-8294427 breaks Windows L&F on all older Windows versions

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8326427 JDK-8294427 breaks Windows L&F on all older Windows versions

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8326695 JDK-8294427 breaks Windows L&F on all older Windows versions

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8326696 JDK-8294427 breaks Windows L&F on all older Windows versions

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8326697 JDK-8294427 breaks Windows L&F on all older Windows versions

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8332389 JDK-8294427 breaks Windows L&F on all older Windows versions

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Closed
            duplicates

            Bug - A problem which impairs or prevents the functions of the product. JDK-8330162 Aero theming of Swing doesn't work in Java 17.0.10 on Windows Server 2016

            • P3 - Major loss of function.
            • Closed
            relates to

            Bug - A problem which impairs or prevents the functions of the product. JDK-8294427 Check boxes and radio buttons have rendering issues on Windows in High DPI env

            • P3 - Major loss of function.
            • Resolved
            links to

            Commit Commit openjdk/jdk11u-dev/a60a5c43

            Commit Commit openjdk/jdk17u-dev/409d27bc

            Commit Commit openjdk/jdk21u-dev/1b7c5aff

            Commit Commit openjdk/jdk22u/160f6508

            Commit Commit openjdk/jdk/f695ca58

            Review Review openjdk/jdk11u-dev/2466

            Review Review openjdk/jdk17u-dev/2148

            Review Review openjdk/jdk21u-dev/200

            Review Review openjdk/jdk22u/25

            Review Review openjdk/jdk/17173

            Activity

              People

                rmahajan Rajat Mahajan
                prr Philip Race
                Votes:
                0 Vote for this issue
                Watchers:
                11 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: