Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8327338

Obsolete unused NUMAPageScanRate product option

XMLWordPrintable

    • gc
    • behavioral
    • minimal
    • The option itself has been a no-op since JDK 15, allowing some control of some esoteric capability. There are no references in an Internet search beyond option lists.
    • add/remove/modify command line option

      Summary

      Obsolete the unused product option NUMAPageScanRate.

      Problem

      The JVM option NUMAPageScanRate is unused since removal of the last use in JDK 22. The effect of the option itself has been a no-op since removal of the Solaris port in JDK 15 because it enabled Solaris specific functionality.

      Solution

      Obsolete the NUMAPageScanRate option with the goal to remove it.

      Specification

      diff --git a/src/hotspot/share/runtime/arguments.cpp b/src/hotspot/share/runtime/arguments.cpp
      index 8f3b9aa11c7..bacbe3f343f 100644
      --- a/src/hotspot/share/runtime/arguments.cpp
      +++ b/src/hotspot/share/runtime/arguments.cpp
      @@ -528,6 +528,7 @@ static SpecialFlag const special_jvm_flags[] = {
         { "DefaultMaxRAMFraction",        JDK_Version::jdk(8),  JDK_Version::jdk(23), JDK_Version::jdk(24) },
         { "TLABStats",                    JDK_Version::jdk(12), JDK_Version::jdk(23), JDK_Version::jdk(24) },
         { "GCLockerEdenExpansionPercent", JDK_Version::undefined(), JDK_Version::jdk(23), JDK_Version::jdk(24) },
      +  { "NUMAPageScanRate",             JDK_Version::undefined(), JDK_Version::jdk(23), JDK_Version::jdk(24) },
       #ifdef ASSERT
         { "DummyObsoleteTestFlag",        JDK_Version::undefined(), JDK_Version::jdk(18), JDK_Version::undefined() },
       #endif
      diff --git a/src/hotspot/share/runtime/globals.hpp b/src/hotspot/share/runtime/globals.hpp
      index 6d3edcf8ed9..13e0573ce4a 100644
      --- a/src/hotspot/share/runtime/globals.hpp
      +++ b/src/hotspot/share/runtime/globals.hpp
      @@ -220,10 +220,6 @@ const int ObjectAlignmentInBytes = 8;
         product(bool, NUMAStats, false,                                           \
                 "Print NUMA stats in detailed heap information")                  \
                                                                                   \
      -  product(uintx, NUMAPageScanRate, 256,                                     \
      -          "Maximum number of pages to include in the page scan procedure")  \
      -          range(0, max_uintx)                                               \
      -                                                                            \
         product(bool, UseAES, false,                                              \
                 "Control whether AES instructions are used when available")       \

            tschatzl Thomas Schatzl
            tschatzl Thomas Schatzl
            Kim Barrett
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: