-
Bug
-
Resolution: Fixed
-
P3
-
23
-
b16
This is the first step of several, in which I will clean up the native compilation code as used by modules. In this first step java.base, java.deskop, jdk.accessibility and jdk.jpackage are left out, since they require more work. The changes in the remaining modules are trivial by comparison.
The changes done here are:
1) A new argument JDK_LIB has been introduced, that is used for linking with other libraries produced by the JDK build. As a follow-up, this will be further cleaned up and generalized, but the goal for this change is just to separate them out from external libraries.
2) The list of libraries given to LIB and JDK_LIB has been sorted in alphabetical order. Note that this change will affect the resulting binaries (since the order libraries are given are stored in the binary), but this change should only be superficial. (If we have symbol clashes between libraries, then we have problems on a whole other level...).
3) The code has been checked for inconsistencies and style guide errors, and a common programming style has been applied to all Lib.gmk and Launcher.gmk files, making sure that all parts follow best practices.
This PR will be followed up by invidual PRs for the modules requiring not jsut trivial cleanup (java.base, java.deskop, jdk.accessibility and jdk.jpackage), and a PR which will unify JDK_LIB handling across platforms, and automatically apply proper dependencies.
The changes done here are:
1) A new argument JDK_LIB has been introduced, that is used for linking with other libraries produced by the JDK build. As a follow-up, this will be further cleaned up and generalized, but the goal for this change is just to separate them out from external libraries.
2) The list of libraries given to LIB and JDK_LIB has been sorted in alphabetical order. Note that this change will affect the resulting binaries (since the order libraries are given are stored in the binary), but this change should only be superficial. (If we have symbol clashes between libraries, then we have problems on a whole other level...).
3) The code has been checked for inconsistencies and style guide errors, and a common programming style has been applied to all Lib.gmk and Launcher.gmk files, making sure that all parts follow best practices.
This PR will be followed up by invidual PRs for the modules requiring not jsut trivial cleanup (java.base, java.deskop, jdk.accessibility and jdk.jpackage), and a PR which will unify JDK_LIB handling across platforms, and automatically apply proper dependencies.
- relates to
-
JDK-8328824 Clean up java.base native compilation
- Resolved
-
JDK-8329086 Clean up java.desktop native compilation
- Resolved
-
JDK-8329102 Clean up jdk.jpackage native compilation
- Resolved
-
JDK-8329178 Clean up jdk.accessibility native compilation
- Resolved
(1 links to)