Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8346787

Fix two C2 IR matching tests for RISC-V

XMLWordPrintable

    • b06
    • riscv
    • linux

      Two IR matching tests added by https://bugs.openjdk.org/browse/JDK-8332268 are failing on RISC-V:
        TEST: compiler/c2/irTests/ModINodeIdealizationTests.java
        TEST: compiler/c2/irTests/ModLNodeIdealizationTests.java

      These two tests require conditional move support. See ModLNode::Ideal & ModLNode::Ideal [1][2].
      But RISC-V base ISA (RV64GCV) does not support conditional move, so we set `ConditionalMoveLimit`
      to 0 for this CPU platform. This change simply skips these two tests for now.

      Some further information:
      An initial version of conditional move based on Zicond extension has been added by:
      https://bugs.openjdk.org/browse/JDK-8344306. But that still lacks performance tunning and we will
      review this `ConditionalMoveLimit` parameter as we go. See https://bugs.openjdk.org/browse/JDK-8346786.

      [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/divnode.cpp#L993
      [2] https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/divnode.cpp#L1253

            fyang Fei Yang
            fyang Fei Yang
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: