-
Type:
Enhancement
-
Resolution: Fixed
-
Priority:
P4
-
Affects Version/s: jfx26
-
Component/s: javafx
-
b22
The jfx repo has a GitHub Action (GHA) workflow that is run in the context of a user's personal fork and provides a sanity test that is useful for reviewers. The README-code-reviews.md guide asks reviewers to ensure that GHA is enabled and is run when reviewing PRs. The CONTRIBUTING.md guide should do the same for PR authors.
See the discussion in the following PR where it was missed:
https://github.com/openjdk/jfx/pull/2016
I also filed SKARA-2647 to provide a warning if a PR is submitted on a repo where GHA is not run.
See the discussion in the following PR where it was missed:
https://github.com/openjdk/jfx/pull/2016
I also filed SKARA-2647 to provide a warning if a PR is submitted on a repo where GHA is not run.
- relates to
-
SKARA-2647 Skara's PR checks should warn if GHA workflows are not enabled in fork
-
- Open
-
- links to
-
Commit(master)
openjdk/jfx/c31d0ef3
-
Review(master)
openjdk/jfx/2028