-
Type:
Enhancement
-
Resolution: Unresolved
-
Priority:
P3
-
None
-
Affects Version/s: None
-
Component/s: bots
-
None
Skara repos such as jdk, jfx, and others are configured to check and present the results of GitHub Actions (GHA) on a PR. These actions are run in the context of the PR author's personal fork of the openjdk repo and only if that user has enabled GHA workflows for their fork.
Skara should report a failing check if GHA is not configured to run on the target repo / branch. This should be a warning in the same way as a failing GHA test run is a warning and should not block integration. It is intended to make it more clear to contributors and reviewers that an extra step is needed.
Here is an open PR where GHA is not enabled (at least as of the time of filing this Enhancement request):
https://github.com/openjdk/jfx/pull/2020
Here are two that we didn't notice until after integration:
https://github.com/openjdk/jfx/pull/2016
https://github.com/openjdk/jfx/pull/2023
Skara should report a failing check if GHA is not configured to run on the target repo / branch. This should be a warning in the same way as a failing GHA test run is a warning and should not block integration. It is intended to make it more clear to contributors and reviewers that an extra step is needed.
Here is an open PR where GHA is not enabled (at least as of the time of filing this Enhancement request):
https://github.com/openjdk/jfx/pull/2020
Here are two that we didn't notice until after integration:
https://github.com/openjdk/jfx/pull/2016
https://github.com/openjdk/jfx/pull/2023
- relates to
-
JDK-8374655 Update CONTRIBUTING.md to ask PR authors to enable GHA in their repo
-
- Resolved
-