Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-1691

Run Jcheck twice in CheckRun if .jcheck/conf has changed

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Fixed
    • Icon: P3 P3
    • 1.0
    • None
    • bots
    • None

      In SKARA-1655 we added a jcheck check to verify the format of .jcheck/conf itself. Unfortunately, this didn't help quite as well as I would have liked. The problem I wanted to solve was that PRs are currently validated using the .jcheck/conf in the target branch, but after being integrated, any change in .jcheck/conf will not have been tested. Simply checking that the .jcheck/conf file can be parsed isn't enough.

      The proper fix here is to check if the PR contains a change to .jcheck/conf and if so we have to run Jcheck twice, once with the .jcheck/conf in the target and once with the new one in the source.

            zsong Zhao Song
            erikj Erik Joelsson
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: