Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-1728

Should iterate over all issues in PullRequestWorkItem in CSR bot

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P4
    • 1.0
    • None
    • bots
    • None

    Description

      While testing SKARA-1714 on the staging environment, I discovered a bug in the PullRequestWorkItem in the CSR bot. The issue is that the for loop does not always iterate over all CSR issues for a pull request.

      For example, if we have two active CSR issues (csr1 and csr2) for one pull request, and we withdraw csr2, the loop will exit early after iterating over csr1 and CSR_UPDATE_MARKER will not be added, which means the PR body will not be updated and the status change of csr2 will not be displayed.

      Also, if we find a withdrawn pr, we need to add CSR_UPDATE_MARKER to the pr body.

      Attachments

        Issue Links

          Activity

            People

              zsong Zhao Song
              zsong Zhao Song
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: