-
Bug
-
Resolution: Duplicate
-
P4
-
None
-
None
-
None
HotSpot changes typically require two reviews (see "Get the required reviews" in https://openjdk.org/guide/#life-of-a-pr ), but the Skara bot currently enforces only one. This has previously caused confusion and discussion when changes were integrated after a single review. I propose updating the Skara bot to require two reviews for all changes labeled with 'hotspot'. If a change is deemed trivial, the number of required reviews can still be reduced to one using the '/reviewers' command.
Additionally, it was discussed that it may be beneficial to require only one review for incremental updates to reduce overhead. In other words, the bot would enforce two reviews for the initial submission, but subsequent incremental changes could be approved with just one re-review.
Additionally, it was discussed that it may be beneficial to require only one review for incremental updates to reduce overhead. In other words, the bot would enforce two reviews for the initial submission, but subsequent incremental changes could be approved with just one re-review.
- duplicates
-
SKARA-2573 Support 2 reviewers by default requirement for hotspot in JDK
-
- Open
-