Uploaded image for project: 'Skara'
  1. Skara
  2. SKARA-2577

Skara bot should enforce the two reviewer requirement for HotSpot changes

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Duplicate
    • Icon: P4 P4
    • None
    • None
    • bots
    • None

      HotSpot changes typically require two reviews (see "Get the required reviews" in https://openjdk.org/guide/#life-of-a-pr ), but the Skara bot currently enforces only one. This has previously caused confusion and discussion when changes were integrated after a single review. I propose updating the Skara bot to require two reviews for all changes labeled with 'hotspot'. If a change is deemed trivial, the number of required reviews can still be reduced to one using the '/reviewers' command.

      Additionally, it was discussed that it may be beneficial to require only one review for incremental updates to reduce overhead. In other words, the bot would enforce two reviews for the initial submission, but subsequent incremental changes could be approved with just one re-review.

            Unassigned Unassigned
            thartmann Tobias Hartmann
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: