I added a comment to:
https://github.com/openjdk/jdk/pull/151
This followed a comment by Coleen but was not in reply to it. Yet the email that was sent out for my comment started:
On Mon, 21 Sep 2020 22:57:55 GMT, Coleen Phillimore <coleenp@openjdk.org> wrote:
>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since
>> the last revision:
>> - Update after Dan and David
>> - Merge branch 'master' into 8238761-asynchrounous-handshakes
>> - Removed double check, fix comment, removed not needed function, updated logs
>> - Fixed double checks
>> Added NSV
>> ProcessResult to enum
>> Fixed logging
>> Moved _active_handshaker to private
>> - Rebase version 1.0
>
> Looks mostly good to me!
https://github.com/openjdk/jdk/pull/151
This followed a comment by Coleen but was not in reply to it. Yet the email that was sent out for my comment started:
On Mon, 21 Sep 2020 22:57:55 GMT, Coleen Phillimore <coleenp@openjdk.org> wrote:
>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since
>> the last revision:
>> - Update after Dan and David
>> - Merge branch 'master' into 8238761-asynchrounous-handshakes
>> - Removed double check, fix comment, removed not needed function, updated logs
>> - Fixed double checks
>> Added NSV
>> ProcessResult to enum
>> Fixed logging
>> Moved _active_handshaker to private
>> - Rebase version 1.0
>
> Looks mostly good to me!
- relates to
-
SKARA-2301 Mail content for a PR comment attributes a quote to the wrong user
-
- Open
-