Uploaded image for project: 'Code Tools'
  1. Code Tools
  2. CODETOOLS-7903775

Add LIBRARY.properties

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Fixed
    • P4
    • jtreg7.5
    • None
    • tools
    • None

    Description

      Currently, libraries are compiled with the compile-time environment (read: "enable-preview mode") of the test that first causes classes in the library to be compiled. This can lead to unstable and unexpected results.

      One possible solution could be to introduce the use of a new file `LIBRARY.properties` (by analogy with `TEST.properties`) to provide an open-ended mechanism for providing jtreg with any necessary attributes about the library -- including whether it needs to be compiled with `--enable-preview`.

      The file would be placed in the directory specified in an `@library` tag, and read when `jtreg` compiles any classes in that library. See `BuildAction.compileLibrary`.

      Putting information like this with the library itself eliminates any churn in the tests that use the library, both when using preview features, and subsequently, when the features eventually become standard.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. JDK-8336108 [lworld] Test libraries compiled with --enable-preview are causing tests failures

          • P3 - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. CODETOOLS-7903790 Use source instead of release option for library compilation

          • P3 - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. CODETOOLS-7903808 IOOBE in compile action when processing class files only

          • P3 - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. CODETOOLS-7903809 Invalid source release N with --enable-preview

          • P3 - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-8337048 [lworld] ProblemList BasicLayerTest until jtreg LIBRARY.properties is supported

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          links to

          Commit Commit(master) openjdk/jtreg/e9bb12e4

          Review Review(master) openjdk/jtreg/212

          Activity

            People

              cstein Christian Stein
              jjg Jonathan Gibbons
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: