Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8255713

JavaFX build should discover Visual Studio compiler on system

    XMLWordPrintable

Details

    Description

      This is a follow-up to JDK-8254691.

       When running a JavaFX github action workflow, we currently hard-code the location of the Visual Studio compiler on the Windows 10 build node that GitHub spins up:

            # FIXME: hard-code the location and version of VS 2019 for now
            VS150COMNTOOLS: "C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\VC\\Auxiliary\\Build"
            MSVC_VER: "14.27.29110"

      This is fragile and will break if and when this changes on the build system. We should instead modify our build logic to discover the location of the VS compiler on a system in the absence of env variables passed into the build.

      Attachments

        Issue Links

          Activity

            People

              kcr Kevin Rushforth
              kcr Kevin Rushforth
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: