This is a follow-up to JDK-8254691.
When running a JavaFX github action workflow, we currently hard-code the location of the Visual Studio compiler on the Windows 10 build node that GitHub spins up:
# FIXME: hard-code the location and version of VS 2019 for now
VS150COMNTOOLS: "C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\VC\\Auxiliary\\Build"
MSVC_VER: "14.27.29110"
This is fragile and will break if and when this changes on the build system. We should instead modify our build logic to discover the location of the VS compiler on a system in the absence of env variables passed into the build.
When running a JavaFX github action workflow, we currently hard-code the location of the Visual Studio compiler on the Windows 10 build node that GitHub spins up:
# FIXME: hard-code the location and version of VS 2019 for now
VS150COMNTOOLS: "C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\\VC\\Auxiliary\\Build"
MSVC_VER: "14.27.29110"
This is fragile and will break if and when this changes on the build system. We should instead modify our build logic to discover the location of the VS compiler on a system in the absence of env variables passed into the build.
- relates to
-
JDK-8256686 GitHub actions: build fails due to upgraded MSVC compiler
-
- Resolved
-
-
-
- Open
-
-
-
- Resolved
-
-
JDK-8266396 Save VSCMD_DEBUG output in Windows build
-
- Resolved
-
(1 links to)