Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8356171

Increase timeout for testcases as preparation for change of default timeout factor

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Unresolved
    • Icon: P4 P4
    • None
    • None
    • hotspot

      This change tries to add timeout to individual testcases so that I am
      able to run with a timeout factor of 1 in the future (JDK-8260555).

      The first commit changes the timeout factor to 0.7, so that I can run
      tests and test the change (it will finally be changed to 1.0). However,
      this commit will be reverted before I integrate. I will also apply
      copyright updates after the review.

      In addition to changing the timeout factor, I have also created a
      library call to parse the timeout factor from the java properties.

      My approach has been to run all test, and afterwards updating those
      that fails due to a timeout factor. The amount of updated testcases is
      huge, and my strategy has been to quadruple the timeout if I could
      not directly see that less was needed (thus the timeout will be the
      same after JDK-8260555 is implemented).

      After the review I will revert the timeout factor change as we first need an
      updated jtreg, and it would also be nice if that change is small and
      easily revertible. I will also add copyright updates after review.

      These fixes have been created when I have plown through testcases:
      JDK-8352719: Add an equals sign to the modules statement
      JDK-8352709: Remove bad timing annotations from WhileOpTest.java
      JDK-8352074: Test MemoryLeak.java seems not to test what it is supposed to test
      CODETOOLS-7903937: JTREG uses timeout factor on socket timeout but not on KEEPALIVE
      CODETOOLS-7903961: Make default timeout configurable

      Sometime in the future I will also fix:
      8260555: Change the default TIMEOUT_FACTOR from 4 to 1

      for which I am awaiting:
      CODETOOLS-7903961 that is fixed in jtreg 7.6, but we are still running 7.5.1+1

            lkorinth Leo Korinth
            lkorinth Leo Korinth
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated: